Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing characters and incorrect uppercase #611

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix missing characters and incorrect uppercase #611

merged 2 commits into from
Oct 18, 2024

Conversation

Syphdias
Copy link
Contributor

Hey, I noticed a few typos in the README and thought I should fix them. Cheers!

@github-actions GitHub Actions
Copy link

This PR has not seen any activity in last 60 days and has been marked as stale

@github-actions github-actions bot added the stale label Aug 19, 2024
@Syphdias
Copy link
Contributor Author

no

@github-actions github-actions bot removed the stale label Aug 20, 2024
apgiorgi
apgiorgi approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@apgiorgi apgiorgi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Syphdias

migueldelucasdoit
migueldelucasdoit approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@migueldelucasdoit migueldelucasdoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Syphdias for your collaboration. Much appreciated!!!

@femrtnz
Copy link
Collaborator

femrtnz commented Oct 17, 2024

Hi @Syphdias I believe you will need to sign your commit so we can merge this. Are you able to follow this doc?

@Syphdias
Copy link
Contributor Author

I even rebased it 🙂

@apgiorgi apgiorgi merged commit 5ce7e37 into doitintl:master Oct 18, 2024
23 checks passed
@apgiorgi
Copy link
Collaborator

Thanks again, @Syphdias

@Syphdias Syphdias deleted the patch-1 branch October 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldelucasdoit migueldelucasdoit migueldelucasdoit approved these changes

@apgiorgi apgiorgi apgiorgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Syphdias @femrtnz @apgiorgi @migueldelucasdoit