fix(contributions): Add Contributing file #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dark0dave <[email protected]>
dark0dave
force-pushed
the
feature/contributing
branch
from
13c2478
to
7f48f37
Compare
femrtnz
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Hey @dark0dave so far LGTM
Can you include details about release process and tagging as well? Thanks
migueldelucasdoit
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Hey @dark0dave thanks for taking the time to compose this document.
Much appreciated!!! LGTM.
Yes I'll add that in annother pr! Thank you! I can not merge at all even after approval. Can we fix this? |
femrtnz
approved these changes
Oct 30, 2024
|
Hey @dark0dave can you please try now merging the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applogies for the other pr, it eventually got out of hand. So I am introducing a contribution document. See the referenced message again. Once again appologies for the spam.