-
-
Notifications
You must be signed in to change notification settings - Fork 14
Refactor schemas for postgres #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e31193
to
ba6512c
Compare
ba6512c
to
615cd36
Compare
1eb7b3d
to
f48ffa5
Compare
810e62d
to
3c01827
Compare
fa8469c
to
c9f7bbe
Compare
2292f9a
to
ea9fbf6
Compare
liuliu-dev
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we handle the hierarchy of postgres schemas. Before for postgres databases each connection could only handle one database and the database could not be changed (because postgres does not have
use [db]
queries and changing the database requires changing the connection). So to simplify changes to support postgres we essentially just equated mysql databases with postgres schemas. This worked fine enough for postgres, but once we started working on doltgres, the synonym started to fail since branches are per-database and not per-schema.This PR has a few changes to accommodate the above:
schema.table
instead of justtable
)Schemas
tab toDefinitions
to avoid two "schema" titles that mean different thingsThe new UI looks like this:

This will not work for doltgres databases yet, just postgres. That's coming next