Skip to content

condense time.Time library calls #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jycor merged 2 commits into from
Dec 30, 2025
Merged

condense time.Time library calls #3358

jycor merged 2 commits into from
Dec 30, 2025

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Dec 30, 2025

Instead of calling Year(), Month(), Day(), Hours(), Minutes(), and Seconds() individually, just use time.Date() and time.Clock().

Benchmarks: dolthub/dolt#10249 (comment)

@jycor jycor merged commit 7ddc25f into main Dec 30, 2025
9 checks passed
@jycor jycor deleted the james/date branch December 30, 2025 19:15
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelamayxie angelamayxie angelamayxie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jycor @angelamayxie