Skip to content

Fix implementation for REVOKE ALL... #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2025
Merged

Fix implementation for REVOKE ALL... #415

merged 9 commits into from
May 23, 2025

Conversation

jycor
Copy link

@jycor jycor commented May 21, 2025

This PR fixes REVOKE ALL [PRIVILEGES], GRANT OPTION ... so that it parse to the same thing as REVOKE ALL PRIVILEGES as they are equivalent in MySQL. The GRANT privilege is already part of all privileges, specifying it is just for clarity.

Additionally, this PR adds syntax support for the IF EXISTS option and IGNORE UNKNOWN USER option that is part of REVOKE statements.

MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/revoke.html
Syntax for: dolthub/dolt#9228

@jycor jycor requested a review from zachmu as a code owner May 21, 2025 18:16
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor merged commit 0f6cf94 into main May 23, 2025
4 checks passed
@jycor jycor deleted the james/revoke branch May 23, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants