Skip to content

Fix missing validation for Optional type parameters in Embeddable properties #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

nakamura-to
Copy link
Member

Summary

  • Fixed a bug where validation logic for Optional type parameters in Embeddable properties was missing
  • The processor now properly validates the wrapped type inside Optional instead of returning null
  • Added comprehensive test case to verify the fix works correctly

Test plan

  • Added new test case IllegalOptionalProperty to verify validation works
  • Updated EmbeddableProcessorTest to include the new test case
  • Enhanced error message reporting in AptinaTestCase for better debugging
  • All existing tests pass
  • Code formatting applied via Spotless

🤖 Generated with Claude Code

…e properties

Fixed a bug where the validation logic for type parameters of Optional properties in Embeddable classes was missing. The processor now properly validates the wrapped type inside Optional instead of returning null.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@github-actions github-actions bot added the fix label Jul 15, 2025
@nakamura-to nakamura-to merged commit b37b0b4 into master Jul 15, 2025
13 checks passed
@nakamura-to nakamura-to deleted the fix/embeddable-property-type-validation branch July 15, 2025 12:43
Copy link

Documentation build overview

📚 doma | 🛠️ build #28861337 (2832172) | 🔍 preview

Files changed

Comparing with latest (15db8a7)

No files changed.

Copy link

Documentation build overview

📚 doma-japanese | 🛠️ build #28861338 (2832172) | 🔍 preview

Files changed

Comparing with latest (15db8a7)

No files changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant