fix: update the Attributes map, instead of using the map provided by the user, preventing two maps from actually being the same reference (issue #177) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzq0301
force-pushed
the
fix-directly-use-same-map
branch
from
3d2ef91 to
29ebd7f
Compare
…the user, preventing two maps from actually being the same reference (issue dominikbraun#177)
tzq0301
force-pushed
the
fix-directly-use-same-map
branch
from
29ebd7f to
2800586
Compare
tzq0301
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #177, every new
Vertexwill contain the same map declared inredVertexAttr, which causes the unexcepted behaviour in the issue.