feat(records): add description as new field #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
Owner
|
Thanks! I'll take a look at this. |
dominikbraun
approved these changes
Mar 6, 2022
Owner
dominikbraun
left a comment
dominikbraun
left a comment
There was a problem hiding this comment.
Looks good to me 👍 I'm not sure whether the description should be displayed by default and a shorter output can be displayed using a flag - or if it is better to not display the description by default and enable a more detailed output using another flag. But that's ok for now.
|
This looks awesome! I'm new to the tool and was wondering about this feature. Any idea when this'll get merged? |
Owner
@jdorseyELS I need to restore a clean state in the repository first, but I'll merge this very soon. |
Author
|
Hi @dominikbraun when will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try at adding an additional description field for the records
Please suggest anything I may have missed, my manual test were succesful.
Fixes #209