Find world file for .jpeg extension #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to load .jpegs with .jgw world files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the amazing add-on! I'm new to this please ignore if I'm way off base here.
Adds the ability to load .jpegs with .jgw world files.
fixes: #568
Because the splitting of extensions is based on the last three characters in the path ([-3:]) the extension in foo.jpeg ends up being "peg" and the path ends up being "foo.j" so for the test I am appending "gw" to "foo.j to get "foo.jgw".
I am new to coding and this seems like it works and is in line with the other extension tests. However it doesn't seem very robust. I wonder if using os.path.splitext() and a list of world file extensions to check would be simpler.
I can imagine a scenario where you have both a jpeg and a png in the same folder with the same name and it would pick up the wrong world file. In which case it should be: if this file extension then look for these world file extensions.
Tiff files with .tiff extensions with world files don't and no internal georeferencing might have the same probelm.