BnkCompiler #117
Merged
BnkCompiler #117
+601
−812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved organistaion of functions for project loader business code.
- Fixed bug where bnk language could be defined but was unused. - Name changes
- Starting initial prep for strategy pattern process for object Names / Ids
- Replaced all uses of RandomNumberGenerator() with GetNextUsableWwiseId() - Reworked the point at which Ids are hashed so that ProjectLoader.cs now controls this rather than individual generators. All Objects include an Id parameter and a Name paramter where the Id is not prescribed. May remove the Name parameter entirely in future as it's not strictly necessary. - Updated Object Generators to account for the removal of Name and use of Id instead. - Some name changes.
- Separated State Path processing out into its own function for better organisation.
- Added CompilerConstants.ActionType
- Changed uses of the Object Name property to Object Id. - Tweak to ActionGenerator.cs.
- Refactored some RandomContainerGenerator.cs code - Changed uses of the Object Name property to Object Id.
- Started implementing improved dialogue event extraction by reusing existing dat file processing.
- Updated HircSorter.cs for uses of the Id property instead of Name. - Commented out AudioProjectExporter.cs as it appears unused and is causing errors.
- Continued implementing dynamic Dialogue Event extraction using existing dat file processing.
- Refactored events and states dat file production. - Updated last remaining uses of Name property with Id property. - Changed names of stuff for clarity. - Removed unused properties and associated code. - Added comments and updated otheres to be more useful.
- Refactored ProjectLoaderHelpers so that the creation of objects is handled by individual functions which can be reused rather than the process being repeated in each section. - Renamed stuff so it's more intelligible and accurate for its function. - Fixed a bug with an accidental name change.
- Added some Todos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removing the random number thing and the surrounding changes, and some refactoring of ProjectLoaderHelpers.cs