bugfix: this being wrong when rest arguments are used #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a previous fix it seems that rest parameters weren't taken into consideration and currently `this` refers to them in the provided test. The test in question is a very simplified variation of a real code. It seems all of the following things are relevant for the bug to occur: 1. method with only a rest parameter 2. usage of `this` 3. usage of the parameter 4. All of the above within a lambda inside the method
Owner
|
Thanks for reporting. It's a tricky spot and I hope the fix is comprehensive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a previous fix it seems that rest parameters weren't taken into consideration and currently
thisrefers to them in the provided test.The test in question is a very simplified variation of a real code.
It seems all of the following things are relevant for the bug to occur:
this