Skip to content

Fix the subarray set method #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dop251 merged 1 commit into from
Nov 20, 2025
Merged

Fix the subarray set method #687

dop251 merged 1 commit into from
Nov 20, 2025
+18 −2

Conversation

@ankur22
Copy link
Contributor

@ankur22 ankur22 commented Nov 20, 2025

What

In the arrayObject path, the set method expects an absolute buffer index including the array's offset, just like in the typedArrayObject which has a var dstOffset. This PR ensures that this has been taken into account for arrayObject.

Closes: #686

@dop251 dop251 merged commit 00ab4e8 into dop251:master Nov 20, 2025
4 checks passed
@dop251
Copy link
Owner

dop251 commented Nov 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypedArray.set ignores offset of subarrays

2 participants

@ankur22 @dop251