-
Notifications
You must be signed in to change notification settings - Fork 614
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
This is awesome! |
Just bumped the parser @dinagraves would there be interest in similar PR's for more data sources? We also have ArgoCD and Azure Devops parsers in our fork at the moment and a modified setup script to allow multi-choice when selecting which parsers to enable. We'd be happy to submit them as separate PR's. |
esac | ||
|
||
if [ $PAGERDUTY_SECRET != "" ]; then | ||
echo $PAGERDUTY_SECRET | tr -d '\n' | gcloud secrets create pager_duty_secret \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to do this part in Terraform - @davidstanke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's one way we could bring secrets management under Terraform (targeting this PagerDuty support PR). 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Once you get that merged in, we'll do a final review and merge this one in!
Yes! Extremely interested in the other parsers! Please submit PR's! |
Co-authored-by: Dina Graves Portman <[email protected]>
Great. 😄 Incoming! ⏳ |
Hi @chris-bridgett-nandos ! We've updated the test configuration (and a few other things). Can you merge |
Hi @davidstanke. Done... I think it's configured to trigger correctly, but is prevented from running still since I'm a first-time contributor. I now see:
(So merging the upstream
|
Hi @davidstanke, mind approving the test-run again? The failing test should now be fixed. |
Merged! Thank you! |
Hi @chris-bridgett-nandos Thanks! |
We've added support for PagerDuty to suit our needs (and have more event sources to come if there is interest). We've done our best to follow the same style as the other parsers and integrated with the setup script.