Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

Pagerduty support #283

Merged
merged 9 commits into from
May 12, 2022
Merged

Pagerduty support #283

merged 9 commits into from
May 12, 2022

Conversation

chris-bridgett-nandos
Copy link
Contributor

We've added support for PagerDuty to suit our needs (and have more event sources to come if there is interest). We've done our best to follow the same style as the other parsers and integrated with the setup script.

@google-cla
Copy link

google-cla bot commented Mar 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@dinagraves
Copy link
Contributor

This is awesome!

@chris-bridgett-nandos
Copy link
Contributor Author

Just bumped the parser flask version, I didn't realise the other parsers had moved on. Should fix the test failure. 🤞

@dinagraves would there be interest in similar PR's for more data sources? We also have ArgoCD and Azure Devops parsers in our fork at the moment and a modified setup script to allow multi-choice when selecting which parsers to enable. We'd be happy to submit them as separate PR's.

esac

if [ $PAGERDUTY_SECRET != "" ]; then
echo $PAGERDUTY_SECRET | tr -d '\n' | gcloud secrets create pager_duty_secret \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to do this part in Terraform - @davidstanke

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's one way we could bring secrets management under Terraform (targeting this PagerDuty support PR). 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Once you get that merged in, we'll do a final review and merge this one in!

@dinagraves
Copy link
Contributor

Just bumped the parser flask version, I didn't realise the other parsers had moved on. Should fix the test failure. 🤞

@dinagraves would there be interest in similar PR's for more data sources? We also have ArgoCD and Azure Devops parsers in our fork at the moment and a modified setup script to allow multi-choice when selecting which parsers to enable. We'd be happy to submit them as separate PR's.

Yes! Extremely interested in the other parsers! Please submit PR's!

Co-authored-by: Dina Graves Portman <[email protected]>
@chris-bridgett-nandos
Copy link
Contributor Author

Yes! Extremely interested in the other parsers! Please submit PR's!

Great. 😄 Incoming! ⏳

@davidstanke
Copy link
Collaborator

Hi @chris-bridgett-nandos ! We've updated the test configuration (and a few other things). Can you merge main of this repo into your fork? I think that will re-trigger the tests, and then we can merge this.

@chris-bridgett-nandos
Copy link
Contributor Author

Hi @davidstanke. Done... I think it's configured to trigger correctly, but is prevented from running still since I'm a first-time contributor.

I now see:

Triggered via pull request 1 minute ago

(So merging the upstream main did trigger), but:

First-time contributors need a maintainer to approve running workflows.

@chris-bridgett-nandos
Copy link
Contributor Author

Hi @davidstanke, mind approving the test-run again? The failing test should now be fixed.

@dinagraves dinagraves merged commit 74da94a into dora-team:main May 12, 2022
@dinagraves
Copy link
Contributor

Merged! Thank you!

@colinfrei
Copy link
Contributor

Hi @chris-bridgett-nandos
You wrote that you have an Azure Devops parser running as well - any chance of a PR for that, or a repo I can take a look at?

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants