New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation_proxy: bytes package install #1266

Open

Abdullah-Albanna wants to merge 6 commits into doronz88:master from Abdullah-Albanna:master

Contributor

Abdullah-Albanna commented Oct 29, 2024 •

edited

Loading

ability to install .ipa/.ipcc using bytes objects

why?

it's way nicer to directly install a package without dealing with paths.

someone could do something like so

import requests
from pymobiledevice3.lockdown import create_using_usbmux
from pymobiledevice3.services.installation_proxy import InstallationProxyService

file = requests.get(
    "https://raw.githubusercontent.com/Abdullah-Albanna/YemenIPCC/refs/heads/master/iPhone7Plus/iOS 15.8.2/Using Default Bundle/iPhone7Plus_iOS_15.8.2_CellularSouthLTE.ipcc",
)

lockdown = create_using_usbmux()

InstallationProxyService(lockdown).install(file.content)

without the need to save it to a file and then installing it and then deleting it !
too much work

this is also valid

from pathlib import Path

file = Path("file.ipa").read_bytes()

lockdown = create_using_usbmux()

InstallationProxyService(lockdown).install(file)

Abdullah-Albanna added 3 commits

October 29, 2024 23:09


          feature: bytes package install

4f8059b


          unnecessary parentheses

cb9f1e0


          style adjusted

f0fa896

Owner

doronz88 commented Oct 29, 2024

I much rather it be explicitly done than implicit. I'm okay with the install_from_bytes(), but it should a different API instead of modifying the current


          made install_from_bytes separate

99272ec

Contributor Author

Abdullah-Albanna commented Oct 30, 2024

that makes sense, should be good now

doronz88 requested changes

View reviewed changes

pymobiledevice3/cli/apps.py Outdated Show resolved Hide resolved

pymobiledevice3/services/installation_proxy.py Outdated Show resolved Hide resolved

pymobiledevice3/services/installation_proxy.py Outdated Show resolved Hide resolved

pymobiledevice3/services/installation_proxy.py

+                          dirs = zip_file.namelist()[1].split('/')
+                          if dirs[0] != 'Payload':
+                              raise AppInstallError('package does not have a payload')

Owner

doronz88 Oct 30, 2024

Suggested change

      
                            raise AppInstallError('package does not have a payload')
          
                            raise InvalidArgumentError('package does not have a payload')

pymobiledevice3/services/installation_proxy.py

+                              raise AppInstallError('package does not have the appropriate folders structure')
+                  except BadZipFile:
+                      raise AppInstallError('invalid bytes package')

Owner

doronz88 Oct 30, 2024

Suggested change

      
                    raise AppInstallError('invalid bytes package')
          
                    raise InvalidArgumentError('invalid bytes package')

pymobiledevice3/services/installation_proxy.py

                       ipcc_mode = package_path.suffix == '.ipcc'
                       if options is None:
                           options = {}
                       if ipcc_mode:
                           options['PackageType'] = 'CarrierBundle'

Owner

doronz88 Oct 30, 2024

remove this diff

pymobiledevice3/services/installation_proxy.py

                       self._watch_completion(handler, ipcc_mode, args)
-                  def upload_ipcc_as_folder(self, file: Path, afc_client: AfcService) -> None:
+                  def upload_ipcc_as_folder(self, file: Union[Path, bytes], afc_client: AfcService) -> None:

Owner

doronz88 Oct 30, 2024

restore this function behavior to the old one. the bytes objects can already be convered to file in install_from_bytes()

Abdullah-Albanna added 2 commits

October 30, 2024 21:45


          slight changes

8c31f8e


          sorted import

1bb6772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet