Skip to content

Fixes: #88 invalid Abstract handler construction declaration #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Fixes: #88 invalid Abstract handler construction declaration #89

merged 1 commit into from
Mar 12, 2025

Conversation

zio-mitch
Copy link
Contributor

No description provided.

@alexmerlin alexmerlin linked an issue Mar 11, 2025 that may be closed by this pull request
Error on nullable dependencies discordant with base class #88
Closed
alexmerlin
alexmerlin requested changes Mar 11, 2025
View reviewed changes
alexmerlin
alexmerlin reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue now is that optional arguments should come after the required ones.

@zio-mitch
Copy link
Contributor Author

The only issue now is that optional arguments should come after the required ones.

Done.

@zio-mitch
Fixes: dotkernel#88, invalid nullable services injection
823f194 
Fixes: dotkernel#88, move optional parameters after required ones
@zio-mitch zio-mitch requested a review from alexmerlin March 12, 2025 10:54
@alexmerlin alexmerlin merged commit ad0a7b3 into dotkernel:main Mar 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmerlin alexmerlin alexmerlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on nullable dependencies discordant with base class
2 participants
@zio-mitch @alexmerlin