Skip to content

Conversation

@lukasz-pyrzyk
Copy link
Contributor

It looks like after #1332 docs about Disassembler settings are out of date. PR unifies them with the code.

Copy link
Contributor

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @lukasz-pyrzyk !

@adamsitnik adamsitnik merged commit bd1c934 into dotnet:master May 23, 2020
@AndreyAkinshin AndreyAkinshin added this to the v0.12.2 milestone May 25, 2020
@lukasz-pyrzyk lukasz-pyrzyk deleted the fix/improvedDisassemblerDocs branch May 28, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants