Change mono-config.js format in the Wasm Tool Chain for ICU support #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naricc
changed the title
Author
lewing
approved these changes
Jul 25, 2020
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
Looks good for the new runtime.
akoeplinger
approved these changes
Jul 28, 2020
Member
|
@AndreyAkinshin do you think we could merge this PR? |
AndreyAkinshin
approved these changes
Jul 29, 2020
Member
|
@akoeplinger looks good to me. |
Member
|
@adamsitnik is on vacation until August 3rd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses an updated format for the mono-config.js generated in the wasm tool chain. This allows wasm to be used with ICU support for globalization (it otherwise would run in invariant globalization mode).
Fixes: #1504