Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for old core runtimes #2505

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove support for old core runtimes #2505

merged 1 commit into from
Sep 17, 2024

Conversation

timcassell
Copy link
Collaborator

@timcassell timcassell commented Jan 14, 2024 •
edited
Loading

Follow-up to #2488.
Explicitly removed support for netcoreapp3.0 and older build targets, instead of letting the build system fail.

@timcassell timcassell added this to the v0.14.0 milestone Jan 14, 2024
@timcassell timcassell force-pushed the remove-old-runtimes branch 2 times, most recently from d836f82 to 76b3b75 Compare January 14, 2024 05:23
@timcassell timcassell marked this pull request as ready for review January 14, 2024 22:06
@timcassell timcassell force-pushed the remove-old-runtimes branch 3 times, most recently from 7097b34 to 120bf20 Compare March 10, 2024 06:58
AndreyAkinshin
AndreyAkinshin approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from my side. If @adamsitnik has no objections, we can merge it.

@timcassell
Copy link
Collaborator Author

No concerns from my side. If @adamsitnik has no objections, we can merge it.

Cool, but we should wait for #2488 to be merged first.

@timcassell timcassell force-pushed the remove-old-runtimes branch 5 times, most recently from 3629dcf to 57a1352 Compare March 14, 2024 03:40
@timcassell timcassell force-pushed the remove-old-runtimes branch 2 times, most recently from 6b6be8d to ae1924b Compare August 30, 2024 16:22
@timcassell
Copy link
Collaborator Author

Merging since #2488 was merged.
@AndreyAkinshin Probably should make the next version v0.15.0 since #2488 was very breaking for old runtimes.

@timcassell timcassell merged commit 3a2d115 into master Sep 17, 2024
14 checks passed
@timcassell timcassell deleted the remove-old-runtimes branch September 17, 2024 17:05
@timcassell timcassell modified the milestones: v0.15.x, v0.14.1 Sep 23, 2024
@timcassell timcassell mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees
No one assigned
Labels
Area:Documentation Area:Toolchains
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@timcassell @AndreyAkinshin