Allow benchmark methods to use names that are used by code generation templates (fixes #2821) #2897
+192
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It may not be strictly necessary, but we should probably also use |
Collaborator
|
Need to fix merge conflicts |
Contributor
Author
|
I might not be able to get to this for a bit so if anyone who is seeing this wants to build off this PR & finish it up I'd be open to that |
timcassell
force-pushed
the
fix-issue-2821-retry
branch
3 times, most recently
from
6c883d0 to
c0f76ca
Compare
Fix missing prefixes. Update Params and Arguments. Remove ValidateNamingConflicts and test more name conflicts.
timcassell
force-pushed
the
fix-issue-2821-retry
branch
from
c0f76ca to
da6cac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2821.
Solution
Uses the suggested solution from #2821, using
base.MethodNamefor instance methods,FQTypeName.MethodNamefor static methods, and prefixing all type/namespace names with theglobal::namespace prefix to avoid accidentally referencing methods with names likeSystemorBenchmarkDotNet.Adds a new test that ensures the method names
SystemandBenchmarkDotNetcan be used as benchmark method names.