Enable central package management in repo #3333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally I'd recommend enabling transivite pinning too: |
paulmedynski
requested changes
May 7, 2025
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
paulmedynski
previously approved these changes
May 7, 2025
benrr101
previously approved these changes
May 7, 2025
mdaigle
reviewed
May 7, 2025
...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Show resolved
Hide resolved
cheenamalhotra
dismissed stale reviews from benrr101 and paulmedynski
via
2ddb065
paulmedynski
previously approved these changes
May 20, 2025
|
@cheenamalhotra Hope you don't mind I resolved your merge conflict for you - just want to get this out the door for the preview release |
paulmedynski
previously approved these changes
May 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
===========================================
- Coverage 92.58% 65.34% -27.24%
===========================================
Files 6 300 +294
Lines 310 65603 +65293
===========================================
+ Hits 287 42871 +42584
- Misses 23 22732 +22709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
previously approved these changes
Jun 5, 2025
cheenamalhotra
force-pushed
the
dev/cheena/central-package-mgmnt
branch
from
fd41121 to
a89ee55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding to modern central package management solution. For reference: https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management#enabling-central-package-management
Also fixed #3330