Skip to content

[Mono.Android] Fix API-36 namespace capitalization error from enumification. #10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 16, 2025

Context: #9914
Context: #10045

In #9914, we completed enumification of Android API-36 and marked it as stable.

A bug in this is that we were not consistent with our capitalization of the Android.Ranging.Ble.CS namespace.

Methods were placed in the Android.Ranging.Ble.CS namespace but enums were placed in the Android.Ranging.Ble.Cs namespace.

Fix the following enums to have the correct "CS" namespace:

Android.Ranging.Ble.CS.BleCsRangingCapabilitiesCsSecurityLevel
Android.Ranging.Ble.CS.BleCsRangingParamsLocationType
Android.Ranging.Ble.CS.BleCsRangingParamsSightType

@jpobst jpobst marked this pull request as ready for review April 16, 2025 21:55
@jpobst jpobst requested a review from jonpryor as a code owner April 16, 2025 21:55
@jonpryor jonpryor merged commit 33763ef into main Apr 21, 2025
57 of 59 checks passed
@jonpryor jonpryor deleted the dev/jpobst/mono-android-ns-fix branch April 21, 2025 19:19
jonpryor pushed a commit that referenced this pull request Apr 21, 2025
Context: #9914
Context: d5152b6
Context: #10045

In #9914 / d5152b6, we completed enumification of Android API-36 and
marked it as stable.

A bug in this is that we were not consistent with our capitalization
of the `Android.Ranging.Ble.CS` namespace:

Methods were placed in the `Android.Ranging.Ble.CS` namespace but
enums were placed in the `Android.Ranging.Ble.Cs` namespace.

Fix the following enums to have the correct "CS" namespace:

  * Android.Ranging.Ble.CS.BleCsRangingCapabilitiesCsSecurityLevel
  * Android.Ranging.Ble.CS.BleCsRangingParamsLocationType
  * Android.Ranging.Ble.CS.BleCsRangingParamsSightType
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants