Skip to content

Commit

Permalink
Fix issue 5972
Browse files Browse the repository at this point in the history
Turns out that we did not wait long enough for the Container graceful stop to occur during restart sequence
  • Loading branch information
karolz-ms committed Nov 15, 2024
1 parent 3b09cd2 commit 9bbd6b2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ static ImmutableArray<HealthReportSnapshot> GetInitialHealthReports(IResource re
}

var reports = annotations.Select(annotation => new HealthReportSnapshot(annotation.Key, null, null, null));
return [..reports];
return [.. reports];
}
}

Expand Down Expand Up @@ -2116,7 +2116,8 @@ async Task StartExecutableOrContainerAsync<T>(T resource) where T : CustomResour
BackoffType = DelayBackoffType.Exponential,
Delay = TimeSpan.FromMilliseconds(200),
UseJitter = true,
MaxRetryAttempts = 6, // Cumulative time for all attempts amounts to about 12 seconds
MaxRetryAttempts = 10, // Cumulative time for all attempts amounts to about 15 seconds
MaxDelay = TimeSpan.FromSeconds(3),
ShouldHandle = new PredicateBuilder().Handle<Exception>(),
OnRetry = (retry) =>
{
Expand Down

0 comments on commit 9bbd6b2

Please sign in to comment.