Merge changes from release/9.0 into main #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Newton-King <[email protected]>
* Enable signing and mark packages as stable * Fix helix package versions for tests * Fix incorrect version of AppHost sdk
Fixes dotnet#6392 Co-authored-by: Karol Zadora-Przylecki <[email protected]>
Exception details are shown behind a button in two places: 1. In the "Message" column of the structured logs table, when an exception exists. 2. In the "Health reports" grid in resource details, when a health report includes exception details. Previously, the stack trace would be shown in a popup when the mouse hovered over the icon, sort of like a tooltip. This commit changes the behaviour so that exception details are shown in the existing text visualizer dialog whenever the icon is clicked. The icon becomes a `FluentButton` for consistency with the menu button to the right of the cell. Also some optimisations in `GridValue`: - Don't use `FluentHighlighter` when the text to highlight is empty, which will be the common case. This improves UI performance. - Remove `MaxDisplayLength`. We never set this property, and it used space on every `GridValue` instance, and we create a lot of these objects. - Remove some redundant DOM elements. - Support adding arbitrary buttons to the right-hand side of the area (used for the "exception details" button). Co-authored-by: Drew Noakes <[email protected]>
…otnet#6446) - We were not detecting containers with the build annotation and reading the image name from a parameter. Instead, it was using the runtime image name which is incorrect. - Expose DockerfileBuildAnnotation to make this possible. - Added test and updated the playground with a docker file sample
…t#6420) * Bump Microsoft.Extensions.Http.Resilience to 9.x * Remove unused properties * Update version * TFM-split Aspire.Hosting.Testing * Don't produce stable versions * Revert stable changes in tests and packages that will go stable. * Multi-target Aspire.Hosting.AppHost as well to Fix dotnet#6429 Also resolve PR feedback. Simplify how Http.Resilience version gets replaced in the templates. --------- Co-authored-by: Damian Edwards <[email protected]> Co-authored-by: Eric Erhardt <[email protected]>
* ConfigureCustomDomain extension method. * Test case fixup. * Add experimental attribute. * React to changes on main. --------- Co-authored-by: Mitch Denny <[email protected]>
* Set docker summaries for all extensions. Saw that it was missing on SqlServer during Damian's demo. * Fix cosmos image * Fix summary * Move package tags hints to <remarks> * Fix tags * Update src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs * Use <remarks> to fix comments --------- Co-authored-by: Sebastien Ros <[email protected]> Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
…otnet#6458) * Make resource HealthStatus computed from HealthReports * Update health reports when they have changed but the status has not --------- Co-authored-by: Adam Ratzman <[email protected]> Co-authored-by: Mitch Denny <[email protected]> (cherry picked from commit a4ef97a)
#### AI description (iteration 1) #### PR Classification Merge branch `release/9.0` into `internal/release/9.0` to integrate recent changes and address specific work items. #### PR Summary This pull request integrates changes from the `release/9.0` branch into `internal/release/9.0`, addressing several work items related to Azure storage and network isolation. - `/tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs`: Added a new test `ConfigureCustomDomainsMutatesIngress` to validate custom domain configuration for Azure Container Apps. - `/src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs`: Introduced a new extension method `ConfigureCustomDomain` to simplify the process of assigning custom domains to Azure Container Apps. Related work items: dotnet#6368, dotnet#6391, dotnet#6433, dotnet#6458, dotnet#6467
…pnetcore/runtime/efcore/extensions #### AI description (iteration 1) #### PR Classification Stabilize packages and flow internal changes from aspnetcore/runtime/efcore/extensions. #### PR Summary This pull request updates package versions to stabilize dependencies and integrate internal changes from various repositories. - `/tests/Shared/RepoTesting/Directory.Packages.Helix.props`: Updated multiple package versions to `9.0.0`. - `/eng/Versions.props`: Updated various package versions to `8.0.11` and `9.0.0`. - `/eng/Version.Details.xml`: Updated dependency versions and SHAs for several packages. - `/NuGet.config`: Adjusted package source mappings and added new disabled package sources.
* [release/9.0] Reject duplicate span ids * WIP * Update
* Don't pass the gauge description as a unit * Don't pass counter descriptions as a unit either --------- Co-authored-by: Benjamin Goose <[email protected]>
…6473) * Make RedisInsight work with WithLifetime(...). * Fix failing test. * Test. * WIP tests * Work around for stopping resource. --------- Co-authored-by: Mitch Denny <[email protected]>
…6451) * Remove Milvus.Client dependency. (dotnet#6435) * Remove Milvus.Client dependency. * namespaces! * Fix random change. * Remove Suppression of stable version in order to produce stable versions. --------- Co-authored-by: Jose Perez Rodriguez <[email protected]>
[release/9.0] Merge branch release/8.2 into release/9.0
* Mark Aspire.Hosting.Python as experimental Fixes dotnet#6298 * PR feedbcak * Move suppression to csproj * Remove stable flag from csproj --------- Co-authored-by: Sebastien Ros <[email protected]>
* Update Azure.Provisioning to latest Respond to latest renames getting the API ready for GA release. Fix dotnet#6376 * Rename properties to match new type names. * Use IsAccessKeyAuthenticationDisabled property * Fix ContainerAppExtensions for new Azure.Provisioning version * Simplify BicepValueFormattableString * Simplify ReferenceExpression to BicepValue<string> logic * Fix Azure Redis test for new property order * Update playground bicep * Fix issue in AspireV8ResourceNamePropertyResolver when resource name has a dash. In .NET Aspire 8.x, when the Aspire resource name has dashes, we used those dashes in the Azure resource name. But we are incorrectly converting them to underscores. Fix dotnet#6474 * Allow customizing Azure ContainerApp resources with ProvisioningBuildOptions. Fix dotnet#6496 --------- Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Jose Perez Rodriguez <[email protected]>
…/9.0 #### AI description (iteration 1) #### PR Classification Code cleanup and dependency updates. #### PR Summary This pull request merges changes from `release/9.0` into `internal/release/9.0`, addressing several work items related to security, dependency updates, and code cleanup. - Removed `MilvusClient` creation logic and health checks from `src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs`. - Updated various package dependencies in `Directory.Packages.props` and `eng/Version.Details.xml`. - Added `AssemblyInfo.cs` to `src/Aspire.Hosting.Python` to mark it as experimental. - Updated container image tags in `src/Aspire.Hosting.Milvus`, `src/Aspire.Hosting.MySql`, `src/Aspire.Hosting.Elasticsearch`, and `src/Aspire.Hosting.Keycloak`. - Removed deprecated package references and suppressed final package version in `src/Aspire.Hosting.Milvus/Aspire.Hosting.Milvus.csproj`. Related work items: dotnet#5994, dotnet#6054, dotnet#6298, dotnet#6377, dotnet#6417, dotnet#6435, dotnet#6451, dotnet#6460, dotnet#6498
- Microsoft.Azure.Cosmos to 3.45.0 - NATS.Net to 2.5.2 - Azure.Identity to 1.13.1
#### AI description (iteration 1) #### PR Classification Code update for version management and package dependencies. #### PR Summary This pull request updates version management and package dependencies to align with the upcoming release. - Updated `PrereleaseVersionLabel` for `Aspire.Npgsql.EntityFrameworkCore.PostgreSQL` in `/eng/Versions.props`. - Updated package versions for `Microsoft.Azure.Cosmos`, `NATS.Net`, and `Azure.Identity` in `/Directory.Packages.props`. Related work items: dotnet#6530, dotnet#6537
- Update dependencies from https://github.com/microsoft/usvc-apiserver build 0.8.13 (dotnet#6579) ---- #### AI description (iteration 1) #### PR Classification Merging branch `release/9.0` into `internal/release/9.0` to address missing Azure Security Pack. #### PR Summary This pull request updates dependencies to address the missing Azure Security Pack as per the S360 action item. - Updated `Microsoft.DeveloperControlPlane` package versions from `0.8.11` to `0.8.13` in `/eng/Version.Details.xml`. - Updated `MicrosoftDeveloperControlPlane` package versions from `0.8.11` to `0.8.13` in `/eng/Versions.props`. Related work items: dotnet#6579
…et#6571) * Don't display telemetry actions when no telemetry * Set branding as 9.0.1 --------- Co-authored-by: James Newton-King <[email protected]> Co-authored-by: Jose Perez Rodriguez <[email protected]>
Merge internal changes
joperezr
requested review from
radical,
eerhardt and
sebastienros
as code owners
eerhardt
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow