Fix not unsubscribing in trace detail on navigation #6666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The trace detail page isn't unsubscribing from repository updates when navigating away. That causes a memory leak by holding onto the
TraceDetail
page instance from the singletonTelemetryRepository
instance.Changes:
UpdateDetailViewData
created a subscription, but the subscription callback also calledUpdateDetailViewData
. In the right circumstances two subscriptions are created but only one is disposed.Profiler showing data leak when repeatedly navigating to and from trace details page:
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):Microsoft Reviewers: Open in CodeFlow