Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate SignalR client for native AOT #56079

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Annotate SignalR client for native AOT #56079

merged 1 commit into from
Jun 10, 2024

Commits on Jun 4, 2024

  1. Annotate SignalR client for native AOT 

    Addresses the following problems:

0. Fix up some infrastructure around TrimmingAttributes to be cleaner.
    - Don't need to condition when to include them. Just always include them if you need it, and the TFM checks will be done for you.
    - Remove duplicate, standalone attribute files
1. HubConnection and ReflectionHelper's usage of finding IAsyncEnumerable interface
2. HubConnection's usage of MakeGenericMethod when using a streaming reader (IAsyncEnumerable or ChannelReader).
    - The only idea I have here is to follow the same approach as we do in DependencyInjection and elsewhere, which is to check for `IsDynamicCodeSupported == false` && `IsValueType` and throw an exception. This enables people to get exceptions during F5, and not only after publishing.
    @eerhardt
    eerhardt committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    798ad84 View commit details
    Browse the repository at this point in the history