-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate SignalR server for native AOT #56460
Merged
Merged
Commits on Jun 25, 2024
-
Annotate SignalR server for native AOT
Fix SignalR Server's usage of MakeGenericMethod when using a streaming reader (IAsyncEnumerable or ChannelReader) following the same approach as the client. Add a runtime check and throw an exception when trying to stream a ValueType in native AOT. Adjust the public annotations: * Remove RequiresUnreferencedCode from AddSignalR * Add RequiresUnreferencedCode to MessagePack and NewtonsoftJson protocols Support trimming and AOT in DefaultHubDispatcher by adding a feature switch to turn off custom awaitable support. Update ObjectMethodExecutor to support trimming and AOT by a new method that doesn't look for custom awaitables, and uses reflection instead of Linq.Expressions.
Configuration menu - View commit details
-
Copy full SHA for 9021cfc - Browse repository at this point
Copy the full SHA 9021cfcView commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 40149a1 - Browse repository at this point
Copy the full SHA 40149a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for de32d11 - Browse repository at this point
Copy the full SHA de32d11View commit details -
Adjust RequiresDynamicCode annotations
* Move RequiresDynamicCode to the whole Hub<T> class, so developers always get a warning when using IHubContext<THub, T>. This helps because THub needs to be a Hub<T>, which will warn as soon as it is used. * Suppress the warning in AddSignalRCore that references HubContext<THub, T> since users will get warnings when they try using IHubContext<THub, T>.
Configuration menu - View commit details
-
Copy full SHA for 93bfe26 - Browse repository at this point
Copy the full SHA 93bfe26View commit details -
Configuration menu - View commit details
-
Copy full SHA for aefb04d - Browse repository at this point
Copy the full SHA aefb04dView commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 035e059 - Browse repository at this point
Copy the full SHA 035e059View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c4317 - Browse repository at this point
Copy the full SHA 12c4317View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89d363b - Browse repository at this point
Copy the full SHA 89d363bView commit details -
Rename the feature switch to IsCustomAwaitableSupported to align with…
… other feature switch naming
Configuration menu - View commit details
-
Copy full SHA for 95a6473 - Browse repository at this point
Copy the full SHA 95a6473View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.