Put package assets in TFM-specific folder #58995
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
BrennanConroy,
JamesNK,
captainsafia,
mgravell and
a team
as code owners
dotnet-issue-labeler
bot
added
the
area-mvc
|
Test build to get packages: https://dev.azure.com/dnceng/internal/_build/results?buildId=2582989&view=results |
BrennanConroy
approved these changes
Nov 15, 2024
|
Thanks for reporting this @loganmj and thanks @BrennanConroy and @wtgodbe for the quick investigation/fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58990
Related: NuGet/Home#6932
When a package has a
buildorbuildmultitargetingfolder without a TFM subfolder, NuGet considers it to be compatible with any TFM. This is causing builds that should be failing with restore errors, to instead later hit a less helpful runtime error.