Skip to content

Fix handling for Name property on DisplayAttribute #61888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix handling for Name property on DisplayAttribute #61888

wants to merge 2 commits into from
+12 −7

Conversation

captainsafia
Copy link
Member

Contributes towards #61589.

There's more work to do to get the implementation to process localization-based resource types (we need to access the attribute at runtime and call the GetName attribute at runtime) but approach this incrementally to make progress.

@github-actions github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label May 12, 2025
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-validation Issues related to model validation in minimal and controller-based APIs and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels May 12, 2025
@BrennanConroy
Copy link
Member

Add a test?

@captainsafia
Copy link
Member Author

@BrennanConroy We already have a test that covers if [Display(Name = "")] is handled but I added a test for the negative case just now.

@build-analysis build-analysis bot mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-validation Issues related to model validation in minimal and controller-based APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @BrennanConroy