Fixing CodeQL angry faces #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garath
reviewed
Mar 12, 2025
test/Microsoft.DotNet.Web.Authentication.Tests/Controllers/AnonymousAttributeController.cs
Show resolved
Hide resolved
garath
previously approved these changes
Mar 12, 2025
garath
approved these changes
Mar 13, 2025
ChadNedzlek
reviewed
Mar 13, 2025
| public class AnonymousAttributeController : ControllerBase | ||
| { | ||
| [AllowAnonymous] |
There was a problem hiding this comment.
This one should just be deleted, since it's identical to the next test. Ideally, you'd have wanted another test that had the "inherit from the controller" behavior tested (you'd just need to not have any Authorize attributes in that controller to keep CodeQL quiet)
ChadNedzlek
reviewed
Mar 13, 2025
| @@ -393,7 +393,7 @@ public string HashPassword(TestUser user, string password) | |||
|
|
|||
| public static string CalculateHash(TestUser user, string password) | |||
| { | |||
| return $":HASH:{user.Name}:{password}"; // lgtm [cs/hardcoded-credentials] Part of unit tests | |||
| return $":HASH:{user.Name}:{password}"; // CodeQL [SM00423] Hardcoded as part of unit tests | |||
There was a problem hiding this comment.
These aren't even hardcoded, this a string interpolation.
There was a problem hiding this comment.
I had to put 25 characters in there for a reason :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/dnceng#5220