Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverloadResolutionAttribute: Copy text from constructor parameter to corresponding property #10650

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rickbrew
Copy link
Contributor

@rickbrew rickbrew commented Nov 7, 2024

I was having trouble figuring out if higher or lower values are "higher" priority. Some classic data structures use lower values for "higher" priorities, for instance. The Priority property does not describe this, I eventually found it in the constructor's priority parameter. This PR copies the sentence from the latter to the former.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

I was having trouble figuring out if higher or lower values are "higher" priority. Some classic data structures use lower values for "higher" priorities, for instance.

This PR copies the text from the constructor's `priority` parameter, which does detail this, over to the corresponding `Priority` property.
@rickbrew rickbrew requested a review from a team as a code owner November 7, 2024 02:37
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 7, 2024
Copy link

Learn Build status updates of commit 45cc912:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/OverloadResolutionPriorityAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rickbrew

This LGTM, and I'll :shipit:

@BillWagner BillWagner merged commit c4ea645 into dotnet:main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.CompilerServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants