CI update - .NET 9 GA #10678
Closed
CI update - .NET 9 GA #10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead. |
gewarren
added
area-Meta
This comment was marked as outdated.
This comment was marked as outdated.
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=476746&view=results source_repo.branch:net9-ga source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
a team,
Rick-Anderson,
HongGit,
kouvel,
StephenMolloy,
mconnew,
AaronRobinsonMSFT,
jkoritzinsky,
halter73,
David-Engel,
cheenamalhotra,
ajcvickers,
cston and
333fred
as code owners
|
Learn Build status updates of commit 0453d40:
|
gewarren
commented
Nov 13, 2024
| @@ -78,7 +82,9 @@ | |||
| <ReturnType>System.Boolean</ReturnType> | |||
| </ReturnValue> | |||
| <Docs> | |||
| <summary>To be added.</summary> | |||
| <summary> | |||
| Gets a value indicating whether to generate schemas with the additionalProperties set to false for .NET objects. | |||
There was a problem hiding this comment.
What does additionalProperties refer to - could we make that a cref? @joperezr
gewarren
commented
Nov 13, 2024
| @@ -59,7 +59,7 @@ | |||
| </Attribute> | |||
| </Attributes> | |||
| <Docs> | |||
| <summary>To be added.</summary> | |||
| <summary>Provides a dictionary used as the AdditionalProperties dictionary on Microsoft.Extensions.AI objects.</summary> | |||
There was a problem hiding this comment.
Same comment here @joperezr
|
Closing as cherry-picking messed up the commits. Will rerun CI and reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View by commit. The last commit is the documentation comments.