Porting new docs for the System.Runtime.Intrinsics namespace #9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsThis handles most of dotnet/runtime#88574. There are some APIs that are missing xml docs entirely that still need to be handled.
|
This comment was marked as outdated.
This comment was marked as outdated.
carlossanlop
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Thanks @tannergooding. I assume for these APIs we mainly care about the summary. Two questions:
- Are you ok with the formatting of the summaries as they were ported?
- Do you plan on adding the missing params, returns, and other non-summary elements?
If the answer is yes to both, let's merge.
There's meant to be two lines, each with their own surrounding
They should exist for types directly in |
tannergooding
force-pushed
the
runtime-88574
branch
from
8008c29
to
afd94bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
carlossanlop
approved these changes
Jul 26, 2023
gewarren
approved these changes
Jul 27, 2023
|
Learn Build status updates of commit 3916983: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit ea2f581: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Genevieve Warren <[email protected]>
|
Learn Build status updates of commit 6de71a7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles most of dotnet/runtime#88574. There are some APIs that are missing xml docs entirely that still need to be handled.