Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActivityTraceId.xml #9200

Merged

Conversation

dealloc
Copy link
Contributor

@dealloc dealloc commented Aug 19, 2023

Correct the size of string returned from ToHexString

As mentioned in #9136 the documentation of ToHexString contradicts itself saying it'll return a 16 bit character string while returning a 32 bit character string.

Summary

Describe your changes here.

Fixes #9136

Correct the size of string returned from ToHexString

fix dotnet#9136
@dealloc dealloc requested a review from a team as a code owner August 19, 2023 14:36
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 19, 2023
@ghost
Copy link

ghost commented Aug 19, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Correct the size of string returned from ToHexString

As mentioned in #9136 the documentation of ToHexString contradicts itself saying it'll return a 16 bit character string while returning a 32 bit character string.

Summary

Describe your changes here.

Fixes #9136

Author: dealloc
Assignees: -
Labels:

area-System.Diagnostics, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit e4ca3ea:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics/ActivityTraceId.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dealloc

@gewarren gewarren merged commit ef63130 into dotnet:main Aug 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Diagnostics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivityTraceId.ToHexString contradicts itself
2 participants