Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting System documentation #9202

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

tannergooding
Copy link
Member

This is the result from the following, to ensure the inheritdoc comments are picked up:

PortToDocs.exe -Docs D:\Users\tagoo\source\repos\dotnet-api-docs\xml -IntelliSense D:\Users\tagoo\source\repos\runtime\artifacts\bin -IncludedAssemblies System.Runtime -IncludedNamespaces System -SkipInterfaceImplementations false -Save true

@tannergooding tannergooding requested review from a team as code owners August 21, 2023 18:10
@ghost ghost assigned tannergooding Aug 21, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 21, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tannergooding
Copy link
Member Author

@carlossanlop, seeing a ton of unrelated whitespace changes. Do you know what's up here?

Hiding whitespace gets it down to just the relevant changes. Is this potentially some newline difference between what the tool is generating and what's checked in?

@learn-build-service-prod
Copy link

Learn Build status updates of commit 5c3870c:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System/Uri.xml 💡Suggestion View Details
xml/System/Byte.xml ✅Succeeded View
xml/System/Char.xml ✅Succeeded View
xml/System/DateOnly.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/DateTimeOffset.xml ✅Succeeded View
xml/System/Decimal.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/Guid.xml ✅Succeeded View
xml/System/Half.xml ✅Succeeded View
xml/System/Int128.xml ✅Succeeded View
xml/System/Int16.xml ✅Succeeded View
xml/System/Int32.xml ✅Succeeded View
xml/System/Int64.xml ✅Succeeded View
xml/System/IntPtr.xml ✅Succeeded View
xml/System/MemoryExtensions.xml ✅Succeeded View
xml/System/SByte.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/TimeOnly.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt128.xml ✅Succeeded View
xml/System/UInt16.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View
xml/System/UInt64.xml ✅Succeeded View
xml/System/UIntPtr.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System/Uri.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#IFormattable#ToString(System.String,System.IFormatProvider) for uid: System.Uri.System#IFormattable#ToString(System.String,System.IFormatProvider).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) for uid: System.Uri.System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop carlossanlop added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 22, 2023
@carlossanlop carlossanlop merged commit 26cdba4 into dotnet:main Aug 28, 2023
2 checks passed
@tannergooding tannergooding deleted the runtime-88561 branch August 28, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants