Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing incorrect guidance for FileInfo.ToString regarding the FileInfo.Name property #9213

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

ryancdotnet
Copy link
Contributor

This change resolves #9212, removing the incorrect guidance to let the important remarks below suffice for additional details and information about file name and path properties.

…entation

Updated FileInfo.xml with FileInfo.ToString() correction and clarification
The important note at the bottom is enough
…entation

Update FileInfo.xml, removing superfluous verbiage
@ryancdotnet ryancdotnet requested a review from a team as a code owner August 24, 2023 03:08
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This change resolves #9212, removing the incorrect guidance to let the important remarks below suffice for additional details and information about file name and path properties.

Author: ryancdotnet
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 6ffa0ee:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/FileInfo.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/System.IO/FileInfo.xml Outdated Show resolved Hide resolved
@learn-build-service-prod

This comment was marked as outdated.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text won't show when the version selector is set to .NET 7 or later, since FileInfo doesn't override ToString() in those versions. But might still be worth updating it.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 4bec294:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/FileInfo.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@jozkee jozkee removed the WIP label Aug 30, 2023
@jozkee jozkee enabled auto-merge (squash) August 30, 2023 22:14
@jozkee jozkee disabled auto-merge August 30, 2023 22:15
@jozkee jozkee merged commit 819f780 into dotnet:main Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileInfo.ToString documentation contains incorrect guidance
4 participants