Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference articles from trim/AOT attribute docs #9238

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 30, 2023

Hopefully this helps with discoverability of the trimming docs. I am linking to https://learn.microsoft.com/dotnet/core/deploying/trimming/fixing-warnings rather than https://learn.microsoft.com/dotnet/core/deploying/trimming/prepare-libraries-for-trimming since I plan to remove parts of the latter.

@elinor-fung @agocke @vitek-karas PTAL.

@sbomer sbomer requested a review from a team as a code owner August 30, 2023 23:39
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 30, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 30, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit 70a37bc:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.CodeAnalysis/DynamicallyAccessedMembersAttribute.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/RequiresDynamicCodeAttribute.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/RequiresUnreferencedCodeAttribute.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/UnconditionalSuppressMessageAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner BillWagner merged commit b205e8c into dotnet:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants