Modified docs for dialogs in PresentationFramework #9239
Conversation
ghost
assigned 
|
Learn Build status updates of commit 046fcec: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@dotnet/docs, I have made the necessary changes to the PR. There is a dependency on these documents for a blog that we will publish by the end of the week. Could you review this PR before that? Also, once the PR is merged how much time does it take to reflect on Microsoft Docs ? |
|
We removed properties |
Publishing happens every weeknight around 10 pm PST. |
I guess you are talking about this. |
This API was removed in .NET 8 Preview 7. I generated the docs after these changes were merged. |
Did you remove it from the reference assembly as well? |
In reference assembly file, HookProc still exists in CommonDialog, however HookProc and Options are removed from FileDialog. https://github.com/dotnet/wpf/blob/7a6188f601e6464a98e11608a9c1948bc3307fff/src/Microsoft.DotNet.Wpf/src/PresentationFramework/ref/PresentationFramework.cs#L3-L50 |
|
Learn Build status updates of commit 90e39e8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Okay, I see that these two APIs were removed in the docs update for Preview 7, and they don't show as applicable to the Windows Desktop 8 moniker 
It is weird that the assembly version 8.0.0.0 is still listed under these APIs though (Options and HookProc). @huangmin-ms Is this a bug? |
Yes, it is. Can you create a bug for us? And this bug may not have a higher priority since there is no impact for production. |
@gewarren , in that case can I go ahead and remove the assembly version 8.0.0.0 from the necessary APIs. In FileDialog.xml there are two types of APIs - 1) which were completely removed 2) which were moved up to the base class |
Yes, you can. It won't affect anything though.
Remove it in both cases. |
Why so ? @gewarren I have made the changes, is this PR ready to merge now? |
|
Learn Build status updates of commit 38d0d41: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
It only appears in the source (ECMAXML) and doesn't affect the published docs at all.
Yes, good for me. |
Co-authored-by: Genevieve Warren <[email protected]>
|
Learn Build status updates of commit a692be0:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/Microsoft.Win32/CommonItemDialog.xml | View | Details | |
| xml/Microsoft.Win32/FileDialog.xml | ✅Succeeded | View | |
| xml/Microsoft.Win32/FileDialogCustomPlace.xml | ✅Succeeded | View | |
| xml/Microsoft.Win32/OpenFileDialog.xml | ✅Succeeded | View | |
| xml/Microsoft.Win32/OpenFolderDialog.xml | ✅Succeeded | View | |
| xml/Microsoft.Win32/SaveFileDialog.xml | ✅Succeeded | View |
xml/Microsoft.Win32/CommonItemDialog.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'NF:shobjidl_core.IFileDialogEvents.OnFileOk'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
Learn Build status updates of commit e370b1b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@gewarren , the build succeeded. Can we go ahead with the merge ? |
Summary
In .NET 8 Preview 7, we made changes to the common dialog API in WPF. We introduced
OpenFolderDialogandCommonIItemDialogAPI and made few changes to(Open\Save)FileDialog,FileDialogandCommonDialogAPIsHere is the API proposal regarding the changes in the API : dotnet/wpf#7689 (comment)
Describing the changes -