Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into live #9257

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Merge main into live #9257

merged 3 commits into from
Sep 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2023

Please don't squash-merge this PR.

antonfirsov and others added 3 commits September 5, 2023 22:24
@antonfirsov
Port doc comments for new S.N.Quic API-s (#9253)
8eed81a
@antonfirsov
Add doc comment for HttpStatusCode.UnprocessableContent (#9252)
7181f4e
@carlossanlop @gewarren
Port docs from System.Windows.Forms (#9243)
8ef9dbd 
* System.Windows.Forms

* System.Windows.Forms.Design

* Update xml/System.Windows.Forms/GiveFeedbackEventArgs.xml

Co-authored-by: Genevieve Warren <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Genevieve Warren <[email protected]>
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Sep 6, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit 8ef9dbd:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Windows.Forms/TaskDialogButtonCollection.xml 💡Suggestion View Details
xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml 💡Suggestion View Details
xml/System.Net.Quic/QuicConnection.xml ✅Succeeded View
xml/System.Net.Quic/QuicError.xml ✅Succeeded View
xml/System.Net.Quic/QuicStream.xml ✅Succeeded View
xml/System.Net/HttpStatusCode.xml ✅Succeeded View
xml/System.Windows.Forms.Design/AnchorEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/BorderSidesEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/DockEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/EventsTab.xml ✅Succeeded View
xml/System.Windows.Forms.Design/FileNameEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/FolderNameEditor.xml ✅Succeeded View
xml/System.Windows.Forms.Design/ShortcutKeysEditor.xml ✅Succeeded View
xml/System.Windows.Forms/AxHost+State.xml ✅Succeeded View
xml/System.Windows.Forms/AxHost+StateConverter.xml ✅Succeeded View
xml/System.Windows.Forms/FolderBrowserDialog.xml ✅Succeeded View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml ✅Succeeded View
xml/System.Windows.Forms/LinkLabel+LinkCollection.xml ✅Succeeded View
xml/System.Windows.Forms/TaskDialogButton.xml ✅Succeeded View
xml/System.Windows.Forms/TaskDialogLinkClickedEventArgs.xml ✅Succeeded View
xml/System.Windows.Forms/TaskDialogPage.xml ✅Succeeded View

xml/System.Windows.Forms/TaskDialogButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheritdoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheritdoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).

xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheritdoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheritdoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@BillWagner BillWagner merged commit ece962d into live Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillWagner @antonfirsov @carlossanlop