-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make semicolons optional between attributes when on separate lines #18303
base: main
Are you sure you want to change the base?
Conversation
7b2ee78
to
386664c
Compare
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
[<MyAttribute(foo ="bar") | ||
MyAttribute(foo ="bar")>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having a test where the second one is not indented far enough? Would it be considered offsides? What about a mixture of semicolons and newlines?
…p/fsharp into multiple-attributes-no-semicolon
@edgarfgp This should probably follow the logic in |
This will also require an rfc, since it's a change to how things are lexed. |
Description
This PR makes semicolons optional between attributes when they appear on separate lines. This improves readability and reduces visual noise in multi-line attribute declarations.
Fixes # (issue, if applicable) There is an issue somewhere but could not find it.
Before this change, semicolons were required between attributes even when on separate lines:
After this change, both forms are valid:
Checklist