Define solution file to build in Build.props#18475
Closed
ViktorHofer wants to merge 1 commit intomainfrom
Closed
Conversation
Build.props is the Arcade extension point to define which projects should get built. Move the define out of DotNetBuild.props so that eventually, that indirection (DotNetBuild.props) can get removed.
Contributor
✅ No release notes required |
akoeplinger
approved these changes
Apr 14, 2025
T-Gro
approved these changes
Apr 14, 2025
Member
Author
|
This needs more work as contrary to other repos, fsharp defines the solution file to build in their scripts instead of in Arcade's Build.proj via a Build.props file. |
Member
|
@ViktorHofer : We can close this now, right? |
Member
Author
|
Yes, right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build.props is the Arcade extension point to define which projects should get built. Move the define out of DotNetBuild.props so that eventually, that indirection (DotNetBuild.props) can get removed.
Description
Fixes # (issue, if applicable)
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: