-
Notifications
You must be signed in to change notification settings - Fork 822
VS: initialize package in the background #18646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
// We have a lock just in case if multi-threads try to create a new IFSharpWorkspaceService - | ||
// but we only want to have a single instance of the FSharpChecker regardless if there are multiple instances of IFSharpWorkspaceService. | ||
// In VS, we only ever have a single IFSharpWorkspaceService, but for testing we may have multiple; we still only want a | ||
// single FSharpChecker instance shared across them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if this is still needed.
Works ok in experimental instance. It seems we don't need the UI thread during package init. |
Thanks for taking this up @majocha . Lets merge this in after it can be locally tested. |
true, | ||
(fun progress _tasks cancellationToken -> | ||
foregroundCancellableTask { | ||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other readers -> this is the significant line.
Description
Fixes #18623
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: