Fix: warn FS0049 on upper union case labels #19003
Draft
+127
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where match clauses without the optional leading bar (
|
) were being treated differently from those with it.The
IsTrueMatchClause
property was checking for both a bar and an arrow, but the bar is actually optional syntax in F#. This meant these two equivalent patterns behaved differently:The same problem affected
function
expressions andtry...with
blocks when the first clause didn't have a bar.This only affects
SynMatchClause
nodes in the AST (used bymatch
,function
, andtry...with
).Not other uses of
->
in F# like type signatures or lambdas.Looking at the parser,
ArrowRange
is onlyNone
when we're in error recovery or dealing with compiler-generated synthetic clauses. user written match clauses always have an arrow, regardless of whether they have a bar.Fixes #18992
Checklist