Obsolete PinNumberingScheme #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's see what breaks
dotnet-policy-service
bot
added
the
area-System.Device.Gpio
krwq
commented
Oct 24, 2024
krwq
commented
Oct 24, 2024
| /// <param name="gpioController">A Gpio Controller if you want to use a specific one</param> | ||
| /// <param name="shouldDispose">True to dispose the Gpio Controller</param> | ||
| public LiquidLevelSwitch(int dataPin, PinValue liquidPresentPinState, GpioController? gpioController = null, PinNumberingScheme pinNumberingScheme = PinNumberingScheme.Logical, bool shouldDispose = true) | ||
| public LiquidLevelSwitch(int dataPin, PinValue liquidPresentPinState, GpioController? gpioController = null, bool shouldDispose = true) |
There was a problem hiding this comment.
since we are touching this we should consider using Pin class here given we're taking controller and a pin
There was a problem hiding this comment.
I think we should add those ctors, not replace them. And better in a separate PR.
…tnet/iot into obsolete-pin-numbering-scheme
joperezr
reviewed
Nov 7, 2024
joperezr
reviewed
Nov 7, 2024
joperezr
reviewed
Nov 7, 2024
Ellerbach
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what breaks and commit fixes here.
Microsoft Reviewers: Open in CodeFlow