FTx: Invert Data and direction position when setting up outputs for SPI mode #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The opcode specification says that data comes before direction. The current code prevents the clock pin from outputting the clock signal
dotnet-policy-service
bot
added
the
area-device-bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opcode specification says that data comes before direction. The current code prevents the clock pin from outputting the clock signal.
I've tested with a FT232H and the previous version made PIN D0 output a constant 3.3v signal. With the changes it outputs the clock signal
Microsoft Reviewers: Open in CodeFlow