[RGen] Use the global alias for CFArray and NSArray. #22616

mandel-macaque · 2025-04-14T20:18:43Z

This way we reduce the chances of collisions with the user namespaces.

This will later allow the code to use "global::" by a single switch. This change just adds the method, we will update the other methods accordingly in later PRs.

Start by updating the method usage and later we will add the fully qualified global usage.

This way we reduce the chances of collisions with the user namespaces.

github-actions · 2025-04-14T20:22:54Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-04-16T12:17:58Z

✅ [CI Build #6f32162] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T12:19:52Z

✅ [PR Build #6f32162] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T12:45:08Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T12:51:56Z

✅ [CI Build #6f32162] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T13:05:09Z

💻 [CI Build #6f32162] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T13:09:07Z

💻 [CI Build #6f32162] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T13:11:16Z

💻 [CI Build #6f32162] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T13:13:22Z

💻 [CI Build #6f32162] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-16T15:15:35Z

🔥 [CI Build #6f32162] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 114 tests passed.

Failures

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 6f32162c4ea74c2f0b7e186a857a8d8f5de7cc21 [PR build]

mandel-macaque · 2025-04-16T16:35:49Z

Failing tests are not related to code changes.

mandel-macaque and others added 5 commits April 14, 2025 12:27

[Rgen] Add a factory for the IdentifierName.

006d682

This will later allow the code to use "global::" by a single switch. This change just adds the method, we will update the other methods accordingly in later PRs.

[RGen] Move to use the factory method to later make it global.

8dad3d7

Start by updating the method usage and later we will add the fully qualified global usage.

Auto-format source code

27d8b19

[RGen] Use the global alias for CFArray and NSArray.

7fb098b

This way we reduce the chances of collisions with the user namespaces.

Auto-format source code

6b9fe1e

This comment has been minimized.

Sign in to view

Base automatically changed from dev/mandel/use-identifier-name-factory to main April 14, 2025 20:34

Merge branch 'main' into dev/mandel/global-ns-cf-array

9c292e0

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Apr 14, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/global-ns-cf-array

6f32162

mandel-macaque merged commit bc62f93 into main Apr 16, 2025
42 of 44 checks passed

mandel-macaque deleted the dev/mandel/global-ns-cf-array branch April 16, 2025 16:35

[RGen] Use the global alias for CFArray and NSArray. #22616

[RGen] Use the global alias for CFArray and NSArray. #22616

Conversation

mandel-macaque commented Apr 14, 2025

github-actions bot commented Apr 14, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 16, 2025

✅ [CI Build #6f32162] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Apr 16, 2025

✅ [PR Build #6f32162] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Apr 16, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Apr 16, 2025

✅ [CI Build #6f32162] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Apr 16, 2025

💻 [CI Build #6f32162] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Apr 16, 2025

💻 [CI Build #6f32162] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Apr 16, 2025

💻 [CI Build #6f32162] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Apr 16, 2025

💻 [CI Build #6f32162] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Apr 16, 2025

🔥 [CI Build #6f32162] Test results 🔥

Test results

Failures

❌ dotnettests tests (MacCatalyst)

Successes

mandel-macaque commented Apr 16, 2025