Skip to content

[RGen] Use the global alias for the CFString methods. #22617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2025
Merged

[RGen] Use the global alias for the CFString methods. #22617

merged 6 commits into from
Apr 15, 2025

Conversation

mandel-macaque
Copy link
Member

As with other changes, we will reduce the chances of a namespace collisions with the user code.

mandel-macaque and others added 5 commits April 14, 2025 12:27
@mandel-macaque
[Rgen] Add a factory for the IdentifierName.
006d682 
This will later allow the code to use "global::" by a single switch.
This change just adds the method, we will update the other methods
accordingly in later PRs.
@mandel-macaque
[RGen] Move to use the factory method to later make it global.
8dad3d7 
Start by updating the method usage and later we will add the fully
qualified global usage.
Auto-format source code
27d8b19
@mandel-macaque
[RGen] Use the global alias for the CFString methods.
8a93fbc 
As with other changes, we will reduce the chances of a namespace
collisions with the user code.
Auto-format source code
7b1a1ff
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Base automatically changed from dev/mandel/use-identifier-name-factory to main April 14, 2025 20:35
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #2cbbea3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2cbbea38af490bd549e1caf2f07b3027c13ee192 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8a93fbc] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 2cbbea38af490bd549e1caf2f07b3027c13ee192 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8a93fbc] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8a93fbc] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8a93fbc] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8a93fbc] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8a93fbc] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #8a93fbc] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

2 tests crashed, 1 tests failed, 104 tests passed.

Failures

❌ dotnettests tests (iOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_ios (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.
  • DotNet tests: TimedOut (Execution timed out after 165 minutes.)

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8a93fbccd4ae09211257694828406c1406232bc0 [PR build]

@mandel-macaque
Copy link
Member Author

Failures are unrelated to the code changes.

@mandel-macaque mandel-macaque merged commit b9b2a6e into main Apr 15, 2025
39 of 44 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/cfstring-global branch April 15, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto