Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 9, 2026

Removes all InternalsVisibleTo attributes that grant the .NET MAUI Community Toolkit access to internal APIs. This reverts the visibility changes previously added in PR #29321 while preserving all other modifications.

Files Modified

  • src/Controls/src/Xaml/Properties/AssemblyInfo.cs - Removed 6 CommunityToolkit assembly references
  • src/Controls/src/Core/Properties/AssemblyInfo.cs - Removed 6 CommunityToolkit assembly references
  • src/Essentials/src/AssemblyInfo/AssemblyInfo.shared.cs - Removed 5 CommunityToolkit assembly references
  • src/Core/src/Properties/AssemblyInfo.cs - Removed 5 CommunityToolkit assembly references

Total: 22 InternalsVisibleTo declarations removed for the following assemblies:

  • CommunityToolkit.Maui
  • CommunityToolkit.Maui.Core
  • CommunityToolkit.Maui.Embedding
  • CommunityToolkit.Maui.UnitTests
  • CommunityToolkit.Maui.Markup
  • CommunityToolkit.Maui.Markup.UnitTests
Original prompt

I want to remove the InternalsVisibleTo attribute for all the .NET MAUI Community Toolkit references. We reverted those changes once here: #29321

Ignore all the other changes, only add back the removal of the InternalsVisibleTo. Target the main branch.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove InternalsVisibleTo attribute for .NET MAUI Toolkit Remove InternalsVisibleTo attributes for .NET MAUI Community Toolkit Jan 9, 2026
Copilot AI requested a review from jfversluis January 9, 2026 12:26
@jfversluis jfversluis marked this pull request as ready for review January 9, 2026 12:36
Copilot AI review requested due to automatic review settings January 9, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes all InternalsVisibleTo attributes that previously granted the .NET MAUI Community Toolkit access to internal APIs, reverting changes from PR #29321. The removal affects 22 declarations across Core, Controls, Xaml, and Essentials assemblies.

Key Changes:

  • Removes internal API visibility for 6 CommunityToolkit assemblies (Maui, Maui.Core, Maui.Embedding, Maui.UnitTests, Maui.Markup, Maui.Markup.UnitTests)
  • Cleans up one duplicate Controls.TestCases.HostApp entry that was inadvertently added in the previous PR

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Essentials/src/AssemblyInfo/AssemblyInfo.shared.cs Removes 5 CommunityToolkit InternalsVisibleTo declarations from Essentials assembly
src/Core/src/Properties/AssemblyInfo.cs Removes 5 CommunityToolkit InternalsVisibleTo declarations from Core assembly
src/Controls/src/Xaml/Properties/AssemblyInfo.cs Removes 6 CommunityToolkit InternalsVisibleTo declarations (including Embedding) from Xaml assembly
src/Controls/src/Core/Properties/AssemblyInfo.cs Removes 6 CommunityToolkit InternalsVisibleTo declarations and cleans up duplicate Controls.TestCases.HostApp entry

@rmarinho
Copy link
Member

rmarinho commented Jan 9, 2026

/azp run maui-pr-devicetests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis added this to the .NET 10.0 SR4 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants