[XSG] Refactor MemberAccess to remove double negatives

[Copilot]

Refactors MemberAccess properties from double negatives (IsGetterInaccessible, IsSetterInaccessible) to positive form (IsGetterAccessible, IsSetterAccessible) for improved readability.

Changes

• PathPart.cs: Renamed properties, flipped defaults to true, updated HasInaccessibleAccessor computation
• PathParser.cs: Simplified assignment (no longer negating)
• Setter.cs, AccessExpressionBuilder.cs: Updated pattern matching from IsSetterInaccessible: true to IsSetterAccessible: false
• BindingCodeWriter.cs: Updated condition checks to use negated positive form
• Tests: Updated test data in SetterBuilderTests, AccessExpressionBuilderTests, BindingRepresentationGenTests

Before/After

// Before
new MemberAccess("Value", IsGetterInaccessible: true, IsSetterInaccessible: true)
public bool HasInaccessibleAccessor => IsGetterInaccessible || IsSetterInaccessible;

// After  
new MemberAccess("Value", IsGetterAccessible: false, IsSetterAccessible: false)
public bool HasInaccessibleAccessor => !IsGetterAccessible || !IsSetterAccessible;

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[XSG][Compiled bindings] Refactor code to remove double negatives in MemberAccess</issue_title>
<issue_description>I always get confused because of MemberAccess properties bool IsGetterInaccessible and IsSetterInaccessible. Let's change them to IsGetterAccessible and IsSetterAccessible.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [XSG][Compiled bindings] Refactor code to remove double negatives in MemberAccess #33448

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

This PR refactors the MemberAccess record properties from double negatives (IsGetterInaccessible, IsSetterInaccessible) to positive form (IsGetterAccessible, IsSetterAccessible) to improve code readability throughout the BindingSourceGen code generator.

Key Changes:

• Property defaults changed from false to true (members are accessible by default)
• Logic inversions applied where properties are checked
• Pattern matching expressions updated to check for false instead of true

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
PathPart.cs	Renamed properties to positive form, updated defaults to true, inverted logic in HasInaccessibleAccessor computation
PathParser.cs	Simplified assignment by removing double negation when setting property values
Setter.cs	Updated pattern matching from IsSetterInaccessible: true to IsSetterAccessible: false
AccessExpressionBuilder.cs	Updated pattern matching from IsGetterInaccessible: true to IsGetterAccessible: false
BindingCodeWriter.cs	Updated condition checks to negate positive properties (!member.IsGetterAccessible)
SetterBuilderTests.cs	Updated test data to use new property names with appropriate boolean values
BindingRepresentationGenTests.cs	Updated test expectations to use new property names
AccessExpressionBuilderTests.cs	Updated test data to use new property names

[simonrozsival]

/azp run maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).