-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update android packages #33450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update android packages #33450
Conversation
…hangeListener This update is required to use the fixed Material Slider binding from dotnet/android-libraries#1335. The Material Slider was missing the addOnChangeListener method, which has been fixed in the latest android-libraries package release. Changes: - Update Xamarin.Google.Android.Material from 1.12.0.5 to 1.13.0.1 - Update required AndroidX dependencies to match Material 1.13.0.1 requirements - Add explicit Ktx package references to resolve transitive dependency conflicts Package Updates: - Xamarin.Google.Android.Material: 1.12.0.5 → 1.13.0.1 - Xamarin.AndroidX.Activity: 1.10.1.3 → 1.12.2 - Xamarin.AndroidX.Lifecycle.LiveData: 2.9.2.1 → 2.10.0 - Added 10 new Ktx and dependency packages required by Material 1.13.0.1 Fixes dotnet/android-libraries#1335
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Xamarin.Google.Android.Material package from version 1.12.0.5 to 1.13.0.1 to incorporate a fix for the Material Slider's missing addOnChangeListener method from the android-libraries binding repository. The update requires coordinated dependency updates to resolve NuGet version conflicts.
Key Changes:
- Primary package update: Material Design Components to 1.13.0.1
- Required dependency updates: Activity 1.12.2, Lifecycle packages to 2.10.0
- Addition of 7 Ktx packages as explicit references to override transitive dependency conflicts
- Two new transitive dependencies: Graphics.Shapes and NavigationEvent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/AndroidX.targets | Updated 3 package versions (Activity, LiveData, Material) and added 9 new package version entries (Ktx packages, Graphics.Shapes, NavigationEvent) |
| src/Core/src/Core.csproj | Added 7 explicit PackageReference entries for Ktx packages to force correct versions and prevent NU1608 errors |
This commit updates all Android/AndroidX NuGet packages to their latest stable versions and removes unnecessary explicit package references that were added as workarounds for version conflicts. Package Updates (11 packages): - Xamarin.Android.Glide: 4.16.0.14 → 5.0.5.1 (major update) - Xamarin.AndroidX.Activity: 1.12.2 → 1.12.2.1 - Xamarin.AndroidX.Browser: 1.8.0.11 → 1.9.0.1 - Xamarin.AndroidX.DynamicAnimation: 1.1.0.3 → 1.1.0.4 - Xamarin.AndroidX.Lifecycle.LiveData: 2.10.0 → 2.10.0.1 - Xamarin.AndroidX.Navigation.*: 2.9.2.1 → 2.9.6.1 (4 packages) - Xamarin.AndroidX.SwipeRefreshLayout: 1.1.0.29 → 1.2.0.1 - Xamarin.AndroidX.Transition: 1.6.0.1 → 1.6.0.2 - Xamarin.AndroidX.Window.WindowJava: 1.4.0.1 → 1.5.1.1 - Xamarin.Firebase.AppIndexing: 120.0.0.26 → 120.0.0.27 - Xamarin.Google.Crypto.Tink.Android: 1.18.0.1 → 1.20.0.1 Removed Unnecessary Packages (9 packages): These were added in the original PR to avoid NU1608 version conflicts, but are no longer needed with all packages updated to latest stable versions: - Xamarin.AndroidX.Activity.Ktx (transitive dependency) - Xamarin.AndroidX.Fragment.Ktx (transitive dependency) - Xamarin.AndroidX.Graphics.Shapes (transitive from Material 1.13.0.1) - Xamarin.AndroidX.Lifecycle.Process (transitive dependency) - Xamarin.AndroidX.Lifecycle.Runtime.Ktx (transitive dependency) - Xamarin.AndroidX.Lifecycle.Runtime.Ktx.Android (transitive dependency) - Xamarin.AndroidX.Lifecycle.ViewModel.Ktx (transitive dependency) - Xamarin.AndroidX.NavigationEvent (transitive from Material 1.13.0.1) - Xamarin.AndroidX.SavedState.SavedState.Ktx (transitive dependency) Removed Explicit References from Core.csproj (10 references): The explicit Ktx and Navigation package references in Core.csproj were only needed to force specific versions and avoid NU1608 conflicts. With all packages at latest versions, these are now correctly resolved transitively. Benefits: - No NU1608 version conflicts - All packages at latest stable versions - Cleaner dependency management (fewer explicit package declarations) - Latest bug fixes and features across Android ecosystem Related: dotnet#33450
These Navigation package references (Fragment, Runtime, Common) were present in the original main branch and are required dependencies. They were mistakenly removed in the previous commit but have now been restored. The Ktx packages remain removed as they are transitive dependencies and not needed with all packages updated to latest versions.
|
Ok, this might be an issue: This means some of these newer <uses-sdk android:minSdkVersion="23" />To get this to be green here, each project with an error we can change to: <SupportedOSPlatformVersion>23</SupportedOSPlatformVersion>But the problem is this will effectively make .NET MAUI's min API level 23, and 21 won't work anymore... |
Summary
This PR updates
Xamarin.Google.Android.Materialfrom1.12.0.5to1.13.0.1to incorporate the fix for Material Slider's missingaddOnChangeListenermethod from dotnet/android-libraries#1335. Also, updated the other packages inorder to avoid the dependency isuses.Background
The Material Slider binding was missing the
addOnChangeListenermethod, which is required for properly handling slider value changes in .NET MAUI applications. This has been fixed in the latest android-libraries package release.Related Issue: dotnet/android-libraries#1335
Changes Made
Files Modified (2 files)
eng/AndroidX.targets- Updated package versions