[Android] Implemented material3 support for RadioButton #33468
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Material Design 3 support for RadioButton on Android, making the radio button UI consistent with Material3 guidelines when the runtime feature is enabled. The implementation conditionally registers the appropriate handler based on the RuntimeFeature.IsMaterial3Enabled flag.
Changes:
- Added
MaterialRadioButtonHandlerclass that createsMaterialRadioButtonplatform views with proper Material3 theming - Implemented conditional handler registration in
AppHostBuilderExtensions.csto use Material3 handler when feature is enabled - Removed unconditional RadioButton handler registration to prevent duplicate assignments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/Handlers/RadioButton/RadioButtonHandler.Android.cs | Added MaterialRadioButtonHandler class that extends RadioButtonHandler and creates MaterialRadioButton with Material3 theming |
| src/Controls/src/Core/Hosting/AppHostBuilderExtensions.cs | Added conditional handler registration for Android using RuntimeFeature.IsMaterial3Enabled flag; removed duplicate unconditional registration |
Tamilarasan-Paranthaman
added
platform/android
area-controls-radiobutton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces support for Material Design 3 radio buttons on Android, making the radio button UI consistent with the latest Material guidelines when the Material3 feature is enabled. The changes ensure that the appropriate handler is used depending on the runtime feature flag.
Android Material Design 3 support:
AppHostBuilderExtensions.cs, usingMaterialRadioButtonHandlerwhen Material3 is enabled, and falling back to the defaultRadioButtonHandlerotherwise.RadioButtonHandlerto prevent duplicate handler assignments.Handler implementation:
MaterialRadioButtonHandlerclass inRadioButtonHandler.Android.cs, which creates aMaterialRadioButtonplatform view with the correct theme wrapper and disables sound effects for consistency.Material Design Spec : RadioButton
Issues Fixed
Fixes #33467
Output